Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants and Message Types #420

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Constants and Message Types #420

merged 1 commit into from
Oct 2, 2021

Conversation

jolheiser
Copy link
Contributor

Addresses #413

This PR also moves message types to an enum-style setup, which just makes it a bit easier to keep consistent rather than "free-form" strings.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@schollz
Copy link
Owner

schollz commented Oct 2, 2021

wonderful! thank you so much for this :) :)

@schollz schollz merged commit a34d29b into schollz:master Oct 2, 2021
@jolheiser jolheiser deleted the const branch October 2, 2021 19:04
@maximbaz
Copy link
Contributor

maximbaz commented Oct 2, 2021

FYI one of the tests in tcp_test.go fails because it tries to modify a now constant 🙂

@jolheiser
Copy link
Contributor Author

jolheiser commented Oct 3, 2021

Very odd. I'm almost positive all the tests passed when I ran them locally.
I'll send in a fix ASAP if no one else has gotten to it.

EDIT: My bad! I did indeed introduce a test failure. I've sent a PR to fix it.
At the very least it shouldn't have caused any broken releases, just the failing test.

@jolheiser jolheiser mentioned this pull request Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants