New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to zip a directory #488
Conversation
This looks good! I think by default the receiver should unzip the directory if it receives a zipped directory using the flag when sending. Do you want to add this as well? |
Should I send a flag to the receiver or unzip any file that ends with |
A flag to the receiver. I think you already added the "TempFile" to the FileInfo so when that gets handled by the recevier they can check that. Unzipping any zip would not be ideal because sometimes you just want to send a zip like a normal file. |
@schollz Is this ok? Should we change |
This is really great!! Thanks so much. I think just one more thing is missing - if you send a directory relative to the current directory I don't think the default behavior should be to save the zip file in the relative directory. I.e. if you do Relative paths are really annoyingly tricky like this, thats why earlier versions of croc didn't support it. Now that it supports it I want to make sure the support continues with added features. If this is getting too complicated feel free to let me know and I can help or tag in and work on this PR too. |
Thanks I will work on this further and will let you know :) |
YES ! this is so great!! I love the "Adding..." UI, very nice! Just one more bug I found testing - |
Yeah I was also having the same issue with the ending /. |
Awesome!!! Really amazing work, I look forward to include this in the next version |
Thanks Glad I could do this! :) |
Related to #487