Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exemple in README.md fails #1

Closed
stephane-martin opened this issue Dec 4, 2018 · 2 comments
Closed

Exemple in README.md fails #1

stephane-martin opened this issue Dec 4, 2018 · 2 comments

Comments

@stephane-martin
Copy link

Hello,

when running the example from the README, the authentication fails:

"crypto/bcrypt: hashedPassword is not the hash of the given password"
@stephane-martin
Copy link
Author

Replacing the EC with elliptic.P256() make it work. I'm not a crypto specialist. Is that OK ?

In any case please update the README with correct parameters.

@schollz
Copy link
Owner

schollz commented Dec 4, 2018

Thanks, I was aware of this: https://github.com/schollz/pake/blob/master/pake_test.go#L142-L175, but I forgot to change it in the readme.

@schollz schollz closed this as completed in 325b2a9 Dec 4, 2018
nexus166 referenced this issue in szampardi/pake Nov 23, 2019
@schollz @nexus166
rebase
166444f 
efbd97a (HEAD -> master, origin/master, origin/HEAD) confirm curve
f35d86a (tag: v2.0.2) Update pake.go
72f2495 (tag: v2.0.1) add SetCurve
d36425e (tag: v2.0.0) v2 for use in wasm go
c672878 add coveralls
0595a58 update tests
bb13327 improve tests
d15e696 (tag: v1.1.1) update deps
325b2a9 Fixes #1
0a79a6b (tag: v1.1.0) add ability to define by string
393a5c4 update tests
41a5a2d add more tests
46bd04c (tag: v1.0.2) fix go.mod
a0e1bcb Update README.md
79e15bd (tag: v1.0.1) add go.mod
ad864d9 handle rand.Read errors
8f049a7 add dynamic hashing
3c9b601 add dynamic hashing
9411b8f Update README.md
f454fe2 Update README.md
7cfc2b0 Update README.md
838ce40 Update README.md
422394d reduce work factor to increase speed
3cebbad Update README.md
b1f00da (tag: v1.0.0) update readme
db5e56e fix mispell
287cec4 update README
e5a966f fix tests
126c7a0 first commit
6465a25 Initial commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephane-martin @schollz