Skip to content

Commit

Permalink
Small refactorings regarding duplicasted code
Browse files Browse the repository at this point in the history
  • Loading branch information
oxzi committed Feb 6, 2019
1 parent 9f4c738 commit 81fc856
Showing 1 changed file with 4 additions and 18 deletions.
22 changes: 4 additions & 18 deletions peerdiscovery.go
Expand Up @@ -130,10 +130,7 @@ func Discover(settings ...Settings) (discoveries []Discovered, err error) {
}

p.RLock()
address := p.settings.MulticastAddress + ":" + p.settings.Port
if p.settings.IPVersion == IPv6 {
address = "[" + p.settings.MulticastAddress + "]:" + p.settings.Port
}
address := net.JoinHostPort(p.settings.MulticastAddress, p.settings.Port)
portNum := p.settings.portNum
payload := p.settings.Payload
tickerDuration := p.settings.Delay
Expand All @@ -147,11 +144,7 @@ func Discover(settings ...Settings) (discoveries []Discovered, err error) {
}

// Open up a connection
network := "udp4"
if p.settings.IPVersion == IPv6 {
network = "udp6"
}
c, err := net.ListenPacket(network, address)
c, err := net.ListenPacket(fmt.Sprintf("udp%d", p.settings.IPVersion), address)
if err != nil {
return
}
Expand Down Expand Up @@ -271,10 +264,7 @@ const (
// from that address to a buffer which is passed to a hander
func (p *peerDiscovery) listen() (recievedBytes []byte, err error) {
p.RLock()
address := p.settings.MulticastAddress + ":" + p.settings.Port
if p.settings.IPVersion == IPv6 {
address = "[" + p.settings.MulticastAddress + "]:" + p.settings.Port
}
address := net.JoinHostPort(p.settings.MulticastAddress, p.settings.Port)
portNum := p.settings.portNum
allowSelf := p.settings.AllowSelf
p.RUnlock()
Expand All @@ -288,11 +278,7 @@ func (p *peerDiscovery) listen() (recievedBytes []byte, err error) {
// log.Println(ifaces)

// Open up a connection
network := "udp4"
if p.settings.IPVersion == IPv6 {
network = "udp6"
}
c, err := net.ListenPacket(network, address)
c, err := net.ListenPacket(fmt.Sprintf("udp%d", p.settings.IPVersion), address)
if err != nil {
return
}
Expand Down

0 comments on commit 81fc856

Please sign in to comment.