Reintroduce Loopback Device Support #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `filterInterfaces` function reduces the useable network interfaces for peer discovery. Due to two changes introduced in v1.6.4[^0] and v1.6.5[^1], a self-discovery over a loopback device was no longer possible. For reasons, a device either holds the loopback flag or the multicast flag, not both together. This commit reflects this. Furthermore, some refactoring of the `filterInterfaces` function was performed to ease its understandability. [^0]: 3ea067d [^1]: 78d5e82
oxzi
added a commit
to dtn7/dtn7-gold
that referenced
this pull request
May 21, 2022
In 9bc28b4, the modules were bumped but, as it seems, not checked afterwards. This commits replaces the wonderful schollz/peerdiscovery module with an upcoming pull request, posted in <schollz/peerdiscovery#31>.
|
Great! Sorry for the late reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filterInterfacesfunction reduces the useable network interfacesfor peer discovery. Due to two changes introduced in v1.6.41 and
v1.6.52, a self-discovery over a loopback device was no longer
possible.
For reasons, a device either holds the loopback flag or the multicast
flag, not both together. This commit reflects this.
Furthermore, some refactoring of the
filterInterfacesfunction wasperformed to ease its understandability.
Footnotes
3ea067d ↩
78d5e82 ↩