Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int64 for maxbytes #23

Closed
fopina opened this issue Jan 29, 2019 · 5 comments · Fixed by #24
Closed

int64 for maxbytes #23

fopina opened this issue Jan 29, 2019 · 5 comments · Fixed by #24

Comments

@fopina
Copy link
Contributor

fopina commented Jan 29, 2019

Anything against having int64 for maxBytes, currentNum and so on?
If we're processing a file, and we're using a progressbar, it's likely it's a huge file :)

int will do in 64bit OS, but not in 32bit one (such as raspbian)

@schollz
Copy link
Owner

schollz commented Jan 30, 2019

@fopina Its a great idea. It'd either have to be a breaking change to the API, or it could be implemented as New64(X) and New64Options(X...). What do you think?

@fopina
Copy link
Contributor Author

fopina commented Jan 30, 2019

Exactly, that's what I started doing here fopina@ebadca8 and then noticed it'd break the API, so wasn't sure about the preferred route.

I'd say no breaking changes are always better indeed

@schollz
Copy link
Owner

schollz commented Jan 30, 2019

Yeah, me too. I guess its fine to use int64 under the hood and have all the public APIs have the Y() and Y64() functions

@fopina
Copy link
Contributor Author

fopina commented Jan 30, 2019

I guess forcing 32bit systems to perform 64bit operations is not an issue as all those float64 were already there. And it's a GUI thing, so few cycles should be done on those :)

Want a PR?

@schollz
Copy link
Owner

schollz commented Jan 30, 2019

@fopina Yes, thanks!

@fopina fopina mentioned this issue Jan 30, 2019
schollz added a commit that referenced this issue Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants