New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
int64 for maxbytes #23
Comments
@fopina Its a great idea. It'd either have to be a breaking change to the API, or it could be implemented as |
Exactly, that's what I started doing here fopina@ebadca8 and then noticed it'd break the API, so wasn't sure about the preferred route. I'd say no breaking changes are always better indeed |
Yeah, me too. I guess its fine to use int64 under the hood and have all the public APIs have the Y() and Y64() functions |
I guess forcing 32bit systems to perform 64bit operations is not an issue as all those Want a PR? |
@fopina Yes, thanks! |
Anything against having
int64
for maxBytes, currentNum and so on?If we're processing a file, and we're using a progressbar, it's likely it's a huge file :)
int
will do in 64bit OS, but not in 32bit one (such as raspbian)The text was updated successfully, but these errors were encountered: