Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make go vet happy #144

Merged
merged 2 commits into from Nov 6, 2022
Merged

Make go vet happy #144

merged 2 commits into from Nov 6, 2022

Conversation

oerlikon
Copy link
Contributor

@oerlikon oerlikon commented Nov 6, 2022

It appears go vet isn't particularly happy about some example names in tests:

progressbar$ go vet .
# github.com/schollz/progressbar/v3
./progressbar_test.go:125:1: ExampleOptionShowCountBigNumber refers to unknown identifier: OptionShowCountBigNumber
./progressbar_test.go:146:1: ExampleOptionShowDescriptionAtLineEnd_WithSpinner refers to unknown field or method: OptionShowDescriptionAtLineEnd.WithSpinner
./progressbar_test.go:163:1: ExampleOptionChangeMax refers to unknown identifier: OptionChangeMax
./progressbar_test.go:171:1: ExampleIgnoreLength_WithIteration refers to unknown identifier: IgnoreLength
./progressbar_test.go:233:1: ExampleIgnoreLength_WithSpeed refers to unknown identifier: IgnoreLength

This change fixes it and adds go vet to the CI workflow.

@schollz schollz merged commit 84d4294 into schollz:main Nov 6, 2022
1 check passed
@schollz
Copy link
Owner

schollz commented Nov 6, 2022

Thanks, this looks great!!

@oerlikon oerlikon deleted the fix-vet-tests branch November 7, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants