Failure to ignore comments, now using tabs instead of spaces for indentation. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res: ['js_comments']' fail unexpectedly. Insert a blank space between "@param" and "{jQuery..." at line schorfES#57 of comments.js restores the expected behavior.
|
Okay, right now I can see the problem. I have to take a closer look into it to solve this problem. I've noticed that it works fine, when using Thank you for your corrected version! |
|
Thank you for your commit. It helped me to find the problem. The mistake was that a comment which appeared more than once was only indexed at its first appearance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to my previous pull request [https://github.com//pull/10/commits]. You (Norman) remarked that the failures where due to using spaces with the comments file rather than tabs. However, I'm able to reproduce when using tabs too (using the comments file as enclosed with this pull requests). Please advice,
Cheers,
Edwin