Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-line files are not caught by newline check. #70

Closed
the-t-in-rtf opened this issue Apr 16, 2021 · 2 comments
Closed

Single-line files are not caught by newline check. #70

the-t-in-rtf opened this issue Apr 16, 2021 · 2 comments
Assignees
@schorfES
Labels
Bug

Comments

@the-t-in-rtf
Copy link

On this line, the newline check is only run if the line number is greater than one. This means that files with a single line of content that lack a trailing newline are not reported as errors.
@the-t-in-rtf the-t-in-rtf mentioned this issue Apr 16, 2021
Closed
@schorfES
Copy link
Owner

Hello @the-t-in-rtf, thank you for the report and pointing to the effected line – sounds reasonable. I am going to test and fix this soonish.

@schorfES schorfES self-assigned this Apr 19, 2021
@schorfES schorfES added the Bug label Apr 19, 2021
schorfES added a commit that referenced this issue Apr 19, 2021
@schorfES
Fix ignored single line files for newlinesEOF check
f12fa1c 
Fixes #70
@schorfES schorfES mentioned this issue Apr 19, 2021
Merged
@schorfES
Copy link
Owner

Hey @the-t-in-rtf,

i've added a test case and a fix into this PR: #72

I think that fixes your issue, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schorfES schorfES

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schorfES @the-t-in-rtf