Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loader on Linux Mint 19.3 Cinnamon #3

Closed
denis-colliot opened this issue Mar 30, 2020 · 10 comments
Closed

Infinite loader on Linux Mint 19.3 Cinnamon #3

denis-colliot opened this issue Mar 30, 2020 · 10 comments

Comments

@denis-colliot
Copy link

denis-colliot commented Mar 30, 2020

Tested version

  • Companion version: 0.3-2 (installed with .deb package)
  • Confluence version: 1000.0.0-04939a47e6a9 (cloud version: <mycompany>.atlassian.net)

System details

  • OS : Linux Mint 19.3 Cinnamon
  • Cinnamon version : 4.4.8
  • Linux Kernel : 5.3.0-42-generic
  • Browsers (both fail) : Chrome 80.0.3987.149 (Official Build) (64-bit) + Firefox 74.0 (64-bit)

Behaviour

Edit popup opens and its inner loader starts rolling indefinitely:

Screenshot from 2020-03-30 15-29-14

@denis-colliot denis-colliot changed the title Doesn't work on Linux Mint 19.3 Cinnamon Infinite loader on Linux Mint 19.3 Cinnamon Mar 30, 2020
@schorschii
Copy link
Owner

Can you please start companion.py in terminal and post the output here?

killall companion.py 
companion.py
# Please click on "Edit with" now. This should produce some output in the terminal.

Which version of Confluence are you using?

@denis-colliot
Copy link
Author

denis-colliot commented Mar 30, 2020

I got the following result just by viewing the file on confluence (I didn't even click on "Edit with"):

$ killall companion.py
$ companion.py
< {"type":"authentication","payload":{"provider":"jwt","payload":"<PAYLOAD>"},"requestID":1}
Error in connection handler
Traceback (most recent call last):
  File "/home/denis/.local/lib/python3.6/site-packages/websockets/server.py", line 191, in handler
    await self.ws_handler(self, path)
  File "/usr/bin/companion.py", line 265, in companionHandler
    await handleJson( websocket, json.loads(request) )
  File "/usr/bin/companion.py", line 64, in handleJson
    currentSiteTitle = requestjson["payload"]["payload"]["siteTitle"]
TypeError: string indices must be integers

I also updated my first comment with confluence version.

@schorschii
Copy link
Owner

Hmm, the first line does not look like the requests from Confluence I discovered. My script expects something like this:

{"type":"authentication","payload":{"provider":"server","payload":{"siteTitle":"Übersicht"}},"requestID":1}

Your output says:

... "provider":"jwt" ...

Is there maybe something else running on your machine which connects to port 31459?

Are you using some kind of dev/beta version? At the bottom of my Confluence I see something like "Powered by Atlassian Confluence 6.15.9". Maybe Atlassian has changed something in a newer version. I'll take a closer look at that.

@denis-colliot
Copy link
Author

denis-colliot commented Mar 30, 2020

Well, JWT is a common authentication mechanism, it's not a really a surprise to see that Confluence is using it.

By the way, I am using a cloud version of Confluence: <mycompany>.atlassian.net

And there is no process on my local machine using the port 31459.

And, no such footer on my Confluence pages, I found the version through the "Help" menu on the sidebar:

Screenshot from 2020-03-30 18-26-43

@schorschii
Copy link
Owner

Yes, it's not a surprise, but I never discovered it before in Companion context.

I haven't tested it yet with a cloud version of confluence. I'll take a closer look at that.

@schorschii
Copy link
Owner

schorschii commented Mar 31, 2020

@denis-colliot
Can you please test the companion script from the current master branch?

@schorschii
Copy link
Owner

@denis-colliot
Where are u?

@denis-colliot
Copy link
Author

Well I have quite a lot of work to do and testing your code is not on my top priorities list right now ;-)

But, as soon as I have a few moments, I'll give it another try and I'll come back to you.

@denis-colliot
Copy link
Author

Just so you know, I tried with your latest master version (c45b8fe) and it worked! \o/

Well I had to accept a system popup asking me if I trusted "atlassian.com" and then magic appeared:
Screenshot from 2020-04-07 19-16-43

Unfortunately, the confluence solution isn't well adapted for my company's problem so I no longer need your script, but keep on the good work!

@schorschii
Copy link
Owner

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants