Add Spiral Twig Integration #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
Engine: Twig
| public function twigRenderer(TwigRenderer $twigRenderer): string | ||
| { | ||
| return $twigRenderer->render( | ||
| 'base.twig', |
There was a problem hiding this comment.
Spiral uses a custom Loader, so not able to use base.html.twig only base.twig which .html part is used by Twig autoescape detection. Need to be checked what happens now and why this is the case.
There was a problem hiding this comment.
[Twig\Error\SyntaxError] An exception has been thrown during the compilation of a template ("Unable to load view
default:base.html, file does not exist.") in "default:base.html". in /tmp/schranz-templating/examples/usages/spiral/vendor/twig/twig/src/Environment.php:521
Comment on lines
+19
to
+38
| // Use a hack to get Twig from the ViewManager as it is not available as an service yet | ||
| $viewManager = $container->get(ViewManager::class); | ||
|
|
||
| $engines = $viewManager->getEngines(); | ||
|
|
||
| $twigEngine = null; | ||
| foreach ($engines as $engine) { | ||
| if ($engine instanceof TwigEngine) { | ||
| $twigEngine = $engine; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (null === $twigEngine) { | ||
| throw new \LogicException( | ||
| \sprintf('Expected "%s" to be registered in the view manager.', TwigEngine::class) | ||
| ); | ||
| } | ||
|
|
||
| return $twigEngine->getEnvironment(new ViewContext()); |
There was a problem hiding this comment.
This is a very hacky implementation getting Twig as a service view ViewManager and via a Fake ViewContext over twigEngine service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Twig Renderer integration into the Spiral Framework.
Sadly there are 2 issues currently: