Set the pins (optionally) in the ctor. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no pins are given, the ctor will default to BLCK=26, LRC=25, DOUT=27. This *should* be compatible with existing code.
|
@schreibfaul1 If you are satisfied with this PR please merge this PR as a squash merge. |
|
Thanks! |
hmax42
pushed a commit
to hmax42/ESP32-audioI2S
that referenced
this pull request
Jun 20, 2021
Set the pins (optionally) in the ctor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #70 and possibly CelliesProjects/wm8978-esp32/issues/4
So now you can use:
Audio audio(BCLK, LRC, DOUT);as a constructor.
Or use
as before and default to 26,25,27.
If no pins are given, the ctor will default to BLCK=26, LRC=25, DOUT=27.
This should be compatible with existing code.
M5Stack Node plays pretty good (On a Fire, not tested on Grey).
The test sketches from ESP32-I2SAudio also work.
Please test this on M5Stack Node.