Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus jumps when I have two tables on the same screen and scroll the above table #369

Closed
Powerade opened this issue Dec 13, 2018 · 4 comments

Comments

@Powerade
Copy link

The version "1.0.0-beta.5" has the following bug:
When I have 2 tables on the same page, focus the bottom one, scroll the top one and then try to write something on the bottom table (which still has the focus on), the focus jumps all over the place.

Like this:
bug

Your Environment

@wcjordan wcjordan mentioned this issue Dec 17, 2018
7 tasks
@wcjordan
Copy link
Member

wcjordan commented Dec 17, 2018

Thanks for reporting this. We designed the v1 branch to work with multiple tables on screen, but hadn't tested it well. There was some default state shared between the tables which I've now reinitialized with each table as part of PR #371.

If possible could you try that PR out on your branch and see if it resolves the issue you're seeing?

@Powerade
Copy link
Author

Powerade commented Dec 17, 2018

Hey man, thanks for the quick response.
I'm trying to run that branch with:
"fixed-data-table-2": "git+https://github.com/schrodinger/fixed-data-table-2.git#multi_table_fix",

But I'm getting the following error:
./node_modules/fixed-data-table-2/main.js Module not found: Can't resolve './internal/FixedDataTableRoot' in '/Users/<user>/fixed-data-table-2-bugs/node_modules/fixed-data-table-2'

Am I doing something wrong here?

@wcjordan
Copy link
Member

Unfortunately the github repo can't be used directly. You'll also need to build the library.

I recommend checking out the branch locally, then running

yarn install && yarn run build-dist && yarn run build-npm

Then using a tool such as yalc to run your library against the local build:

wcjordan added a commit that referenced this issue Dec 24, 2018
* Fixes #369 for issues when using multiple tables
@wcjordan
Copy link
Member

This is now fixed w/ #371 and published as v1.0.0-beta.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants