Fix column dragging in IE11 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2017 18:19
KamranAsif
suggested changes
Jan 18, 2017
| var isFixed = !!this.state.headFixedColumns.find(function(column) { | ||
| return column.props.columnKey === columnKey; | ||
| // No native support in IE11 for find, findIndex, or includes, so using every. | ||
| var isFixed = !this.state.headFixedColumns.every(function(column) { |
There was a problem hiding this comment.
instead of !every use some
There was a problem hiding this comment.
Ah, didn't notice that some was native and supported! Thank you, that's much better - changed.
|
LGTM. I'll merge after tests pass |
KamranAsif
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drag reordering did not work at all in IE11 because Array.prototype.find is not supported in it
Also, add host: 0.0.0.0 to the webpack-client.config.js so that developers can use VMs (such as when testing in IE11)
Motivation and Context
SS-18621
How Has This Been Tested?
Tested in column draggable example
Types of changes
Checklist: