Fix Server Side rendering support using suggested PR from fixed-data-table #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. |
There was a problem hiding this comment.
Needs to be updated to our new copyright
/**
* Copyright Schrodinger, LLC
*/
|
LGTM after we verify this works with example provided here: #11 |
|
Verified it fixes the example. Also verified it still works as expected in LiveDesign. |
|
I spin up the dev server |
|
Done, everything looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
have some state that tells us we are in the first pass and always render positions with left and top (since we know all browsers support this but not translate pos), then on any other render from there we can use the fancy translate3d stuff
Motivation and Context
Server side rendering currently produces different markup than client rendering
#11
How Has This Been Tested?
I haven't tried this out. I'll verify everything still works with client side rendering.
We should put together a server side example / sandbox for testing
Types of changes
Checklist: