update viewportHeight when height changes (closes #120) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm being impacted by this as well. I really need |
KamranAsif
suggested changes
Mar 7, 2017
src/FixedDataTable.js
Outdated
| // Number of rows changed, try to scroll to the row from before the | ||
| // change | ||
| var viewportHeight = | ||
| (props.height === undefined ? props.maxHeight : props.height) - | ||
| (props.headerHeight || 0) - | ||
| (props.footerHeight || 0) - | ||
| (props.groupHeaderHeight || 0); | ||
|
|
||
| var oldViewportHeight = this._scrollHelper._viewportHeight; |
There was a problem hiding this comment.
Can you fix the indent here
|
@veej @bradbirnbaum Sorry for the delay. I added a comment and forgot to hit start review /facepalm |
|
Can you add a unit test for ensure we don't break this in the future? It should be very simple to copy this one and modify it slightly: https://github.com/schrodinger/fixed-data-table-2/blob/master/src/FixedDataTableRoot-test.js#L94 |
KamranAsif
approved these changes
Mar 8, 2017
|
Published 0.7.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per issue #120, viewportHeight should be updated when height changes.
Description
Motivation and Context
Issue #120
How Has This Been Tested?
Modify ScrollToExample to receive width, height from local state. Initialize them to zero and update the size in
componentDidMount.Pass
scrollToRow={0}when no row is found (like at first render).Previous to this commit, fdt will start with scroll position > 0.
After this commit, fdt will start at the right scroll position.
Screenshots (if appropriate):
Types of changes
Checklist: