Fix regression around column resize state being retained too aggresively #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcjordan
commented
Jan 5, 2018
| @@ -9,109 +9,78 @@ const { DateCell, ImageCell, LinkCell, TextCell } = require('./helpers/cells'); | |||
| const { Table, Column, Cell } = require('fixed-data-table-2'); | |||
| const React = require('react'); | |||
|
|
|||
There was a problem hiding this comment.
You can ignore changes in this file. I accidentally committed when working on #268. Reverting now
| @@ -1177,7 +1177,9 @@ var FixedDataTable = createReactClass({ | |||
| } | |||
|
|
|||
| var columnResizingData; | |||
| if (props.isColumnResizing || (oldState && oldState.isColumnResizing)) { | |||
There was a problem hiding this comment.
Just adding the props.isColumnResizing === undefined condition here so we only use oldState when isColumnResizing is not specified in the props.
miskreant
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only retain when the prop is undefined, not when explicitly set to false.
@miskreant @quixotically could one of you take a look when you get a chance?
Description
#276 is happening because we're retaining the old column state even when resizing is stopped.
Motivation and Context
Fix #276
How Has This Been Tested?
Tested on the test case from #268 and the column resize example.
Screenshots (if appropriate):
Types of changes
Checklist: