Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Babel 6 compiler and adding testing infrastructure #29

Merged
merged 10 commits into from
Jul 14, 2016

Conversation

KamranAsif
Copy link
Contributor

Description

  • Switched to babel 6
  • Removed .react file extensions
  • Switched requires to import statments
  • Removed erroneous trailing commas
  • Added testing framework with Mocha and Chai

Motivation and Context

Lack of testing

How Has This Been Tested?

It does itself :D

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@KamranAsif KamranAsif added this to the 0.6.7 milestone Jul 13, 2016

/**
* Binary heap
*/
_heap: Array<number>;
//_heap: Array<number>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wcjordan I think this used flow..Not sure if theres a better solution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya these look like flow annotations. The code in constructor works fine with xs: Array though... I wonder if the transforms only handle a subset of cases...

Should we leave the variables but document with jsdoc instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@wcjordan
Copy link
Member

lgtm. It's probably worth adding documentation or an example PR for adding a test.

@KamranAsif
Copy link
Contributor Author

@burakcan I re-added all the commas and included babel-plugin-syntax-trailing-function-commas
I had to do a rebase and push forward because of the file renames

@KamranAsif
Copy link
Contributor Author

@wcjordan Lets do document/example PR as a follow up

@KamranAsif KamranAsif merged commit dffeb95 into schrodinger:master Jul 14, 2016
@KamranAsif KamranAsif mentioned this pull request Jul 14, 2016
7 tasks
@burakcan
Copy link
Contributor

Just upgraded and working like a charm 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants