-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to Babel 6 compiler and adding testing infrastructure #29
Conversation
|
||
/** | ||
* Binary heap | ||
*/ | ||
_heap: Array<number>; | ||
//_heap: Array<number>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wcjordan I think this used flow..Not sure if theres a better solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya these look like flow annotations. The code in constructor works fine with xs: Array though... I wonder if the transforms only handle a subset of cases...
Should we leave the variables but document with jsdoc instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
lgtm. It's probably worth adding documentation or an example PR for adding a test. |
@burakcan I re-added all the commas and included babel-plugin-syntax-trailing-function-commas |
@wcjordan Lets do document/example PR as a follow up |
Just upgraded and working like a charm 💯 |
Description
Motivation and Context
Lack of testing
How Has This Been Tested?
It does itself :D
Types of changes
Checklist: