Fixing column drag scroll with cell recycling #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +64,7 @@ var FixedDataTableCellDefault = React.createClass({ | |||
| }, | |||
|
|
|||
| render() { | |||
| var {height, width, style, className, children, columnKey, ...props} = this.props; | |||
| var {height, width, style, className, children, columnKey, rowIndex, ...props} = this.props; | |||
There was a problem hiding this comment.
Interesting destructing to remove props...
Confused me for a second so might be worth adding a comment as to why it's done. Maybe this is just a common pattern I haven't seen yet though.
There was a problem hiding this comment.
Saw it done here: https://github.com/facebook/fixed-data-table/pull/426/files
|
lgtm, thanks for the quick turn around! |
|
new change lgtm. Why was that necessary to add? Was that missed from the column drag scroll feature previously? |
|
Yeah it should have been included before. I noticed it in LD because we have a separate component for the header and we sync the horizontal scroll via the callback |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix column drag and reorder when allowCellRecycling is enabled. This was causing issues because the original cell that the event started on was being destroyed.
Motivation and Context
#39
SS-16510
How Has This Been Tested?
Tested locally with reorder example
Types of changes
Checklist: