Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in Master #480

Merged
merged 6 commits into from
Sep 18, 2019
Merged

Update dependencies in Master #480

merged 6 commits into from
Sep 18, 2019

Conversation

pradeepnschrodinger
Copy link
Collaborator

@pradeepnschrodinger pradeepnschrodinger commented Sep 12, 2019 •
edited
Loading

(similar to #473)

Description

Redone all the steps for updating the dependencies

Motivation and Context

Fixes SS-28030

How Has This Been Tested?

Tested on LD and site examples.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@pradeepnschrodinger pradeepnschrodinger changed the title Update dependencies (master) Update dependencies in Master Sep 12, 2019
wcjordan
wcjordan approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@wcjordan wcjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! Was there anything new hear outside of the changes we made to the beta branch?

lgtm

@pradeepnschrodinger
Copy link
Collaborator Author

pradeepnschrodinger commented Sep 13, 2019 •
edited
Loading

Was there anything new here outside of the changes we made to the beta branch?

Nope, none from my side. If there were other changes (from the tools), it probably went unnoticed since the update tools probably worked over the changes from master -> beta.
We'll probably need to update again after beta is merged. I'll put a PR for that at the end. For now I'll merge this.

@pradeepnschrodinger pradeepnschrodinger merged commit f0b485e into master Sep 18, 2019
pradeepnschrodinger added a commit that referenced this pull request Sep 18, 2019
@pradeepnschrodinger
Squashed commit of the following:
afac97c 
commit 6371b4b
Author: pradeepnschrodinger <niranjan.pradeep@schrodinger.com>
Date:   Wed Sep 18 03:33:16 2019 +0000

    Version 0.8.28

commit f0b485e
Author: Niranjan Pradeep <41563608+pradeepnschrodinger@users.noreply.github.com>
Date:   Wed Sep 18 08:46:02 2019 +0530

    Update dependencies in Master (#480)

    * `postcss` updated
    * HMR enabled for CSS
    * `mini-css-extract-plugin` replaces `extract-text-webpack-plugin`
    * `webpack` updated to v4
    * Babel upgraded to v7
    * other packages updated
    * Calypso codemods ran `calypso-codemods commonjs-imports,commonjs-exports ./src ./examples`.
    So now ES6 styled exports/imports are used throughout the code base (except for 1 or 2 edge cases)
Merge branch 'master' into v1.0-beta
@pradeepnschrodinger pradeepnschrodinger mentioned this pull request Sep 18, 2019
Merged
pradeepnschrodinger added a commit that referenced this pull request Sep 19, 2019
@pradeepnschrodinger
Merge master to v1.0-beta (#484)
f65862d 
dependencies are updated (following #480)
@pradeepnschrodinger pradeepnschrodinger deleted the master-update-dependencies branch September 24, 2019 09:55
@snyk-bot snyk-bot mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcjordan wcjordan wcjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pradeepnschrodinger @wcjordan