Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria selected and row attributes #491

Merged
merged 6 commits into from
Oct 29, 2019

Conversation

louiebert
Copy link
Contributor

@louiebert louiebert commented Oct 16, 2019

Added further capabilities for rendering aria attributes

Description

Added a prop onto the Table for if it is multi-selectable. Additionally, added a callback function for adding DOM element attributes to the row div.

Motivation and Context

Creates more support for screenreaders and user customization.
Fixes #490

How Has This Been Tested?

Given that there aren't any existing tests on DOM attributes rendered, or an installed library that would do so, I did not test these changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

src/FixedDataTable.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@pradeepnschrodinger pradeepnschrodinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wcjordan , should we also have rowAttributesGetter work for the headers (including group header) ? If so, how should it work? Maybe it can specify the first argument with -1 and -2 for the header and group header respectively. Or maybe something like "header", "group-header".

And how should it work with multi level column headers (which will come in v2) ?

src/FixedDataTableBufferedRows.js Outdated Show resolved Hide resolved
@wcjordan
Copy link
Member

@wcjordan , should we also have rowAttributesGetter work for the headers (including group header) ? If so, how should it work? Maybe it can specify the first argument with -1 and -2 for the header and group header respectively. Or maybe something like "header", "group-header".

And how should it work with multi level column headers (which will come in v2) ?

I'm not too sure. For now I recommend we leave it off, and wait to see if someone requests it down the road.

Copy link
Collaborator

@pradeepnschrodinger pradeepnschrodinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looking good from my side

Copy link
Member

@wcjordan wcjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @pradeepnschrodinger I think we can go ahead and merge unless there's something you'd like us to look further at.

@louiebert
Copy link
Contributor Author

louiebert commented Oct 29, 2019

@pradeepnschrodinger this hasn't gotten any attention in a little while. Is everything good to merge?

@pradeepnschrodinger pradeepnschrodinger merged commit 48a3118 into schrodinger:master Oct 29, 2019
@pradeepnschrodinger
Copy link
Collaborator

Sorry for the delays :(

Released with v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aria attributes for selection
5 participants