Remove unsafe react lifecycle hooks (Fixes #492) #509

boxfoot · 2020-01-15T21:24:21Z

Removes all use of componentWillMount and componentWillReceive Props

Motivation and Context

As discussed in #492 -- React will be deprecating some of its lifecycle methods in the next major version. https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

How Has This Been Tested?

All unit tests pass, and all of the examples in the sample site also work as expected.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.

boxfoot · 2020-01-16T15:05:58Z

Update: running yarn run site-dev-server (or npm) still doesn't work, but running the command in the script directly does. I've been able to run the dev site and verify that all of the examples continue to work as expected with these changes.

wcjordan · 2020-02-17T16:31:18Z

Awesome, thanks for putting this together, and apologies for our delays responding. This looks good to me. @pradeepnschrodinger could you take a look at well?

I have 2 concerns which I think we should explore before approving for merge.

When I tried this w/ the autoscroll example and updated an input some sort of infinite loop happened. Could you investigate and see if that's something we can fix?
Our peer dependencies currently suggest FDT supports React 13 & 14. But I couldn't get the examples to work on those versions (on this PR or master). We should either confirm these changes continue to work on those versions, or schedule them for a future release where we drop support for those versions. @pradeepnschrodinger do you have a suggestion here?

boxfoot · 2020-02-18T20:29:07Z

Thanks for the review @wcjordan. I think I've fixed the infinite loop issue. It sounds like the React 13/14 issue is beyond the scope of this PR so I'll leave it to you and @pradeepnschrodinger to weigh in on the right approach there.

wcjordan · 2020-02-18T22:26:42Z

Awesome, thank you. Niranjan & I will work out dealing w/ React 13 & 14 and get back to you shortly on merging this.

pradeepnschrodinger

Looks good to me

pradeepnschrodinger · 2020-02-19T10:45:53Z

src/FixedDataTableCell.js

@@ -125,7 +125,10 @@ class FixedDataTableCell extends React.Component {
    return false;
  }

-  componentWillReceiveProps(props) {
+  componentDidUpdate(prevProps) {
+    if (prevProps === this.props) return;


Is this only true when the component gets rerendered due to a state change within itself?
Also can you reformat this to:

if (prevProps === this.props) { return; }

In the long term, can we skip the extra rerender through use of getDerivedStateFromProps ? @wcjordan

Also, since getDerivedStateFromProps was added in React v16.3, will this mean we'll deprecate every react version under v16.3.

Yuck, we don't want to deprecate support for everything under 16.3. @pradeepnschrodinger could you ticket out the idea of using getDerivedStateFromProps and we can discuss when may make sense to do that on our roadmap?

Created #512

Great, thanks

pradeepnschrodinger · 2020-02-19T10:54:17Z

src/FixedDataTableContainer.js

-  componentWillReceiveProps(nextProps) {
+  componentDidUpdate(prevProps) {
+    // Only react to prop changes - ignore updates due to internal state
+    if (this.props === prevProps) return;


reformat to

if (this.props === prevProps) { return; }

pradeepnschrodinger · 2020-02-19T10:56:15Z

src/FixedDataTableContainer.js


-    this.setState(boundState);
+  update() {
+    this.setState(this.getBoundState());


Thanks. Not sure how this.setState worked in the constructor earlier.

wcjordan · 2020-02-19T16:53:27Z

@boxfoot could you update the package.json peerDependencies for react & react-dom to require "^15.3.0"?

I've created a v1.0.x branch which will use if we patch anything else to v1.0 and we'll target master for a v1.1 release where we drop support for React 13, 14, & early 15 (FDT has already stopped working with those versions given our use of React.PureComponent...)

boxfoot · 2020-02-19T19:50:10Z

@wcjordan should it be ^15.3.0 || ^16.0.0 to allow React 16?

wcjordan · 2020-02-19T20:10:31Z

Good call, now that react is using the major version number ^ isn't enough. Let's do ">=15.3.0"

boxfoot · 2020-02-19T21:24:26Z

All changes committed (and squashed)

wcjordan · 2020-02-19T23:08:11Z

Sweet, thanks. I've merged to mainline and we'll release w/ v1.1.0

pradeepnschrodinger · 2020-04-07T22:22:28Z

We've changed few parts seen in this PR as it had led to some bugs with one of our applications. We also believe that it leads to breakages for other users.

See the cause of the bug and explanation, along with the full changes in PR: #523.

boxfoot · 2020-04-08T20:59:27Z

Thanks for the update, good to know!

wcjordan · 2020-04-14T15:13:17Z

This is now released w/ v1.1.

boxfoot requested a review from pradeepnschrodinger January 16, 2020 17:07

pradeepnschrodinger approved these changes Feb 19, 2020

View reviewed changes

pradeepnschrodinger mentioned this pull request Feb 19, 2020

Migrate to using getDerivedStateFromProps #512

Closed

boxfoot force-pushed the master branch from 944f0ed to 6056996 Compare February 19, 2020 19:55

boxfoot force-pushed the master branch 2 times, most recently from 4413526 to d28f9cd Compare February 19, 2020 21:21

Remove unsafe react lifecycle hooks

88dc96e

boxfoot force-pushed the master branch from d28f9cd to 88dc96e Compare February 19, 2020 21:22

wcjordan merged commit a59831d into schrodinger:master Feb 19, 2020

wcjordan added this to the v1.1 milestone Mar 3, 2020

pradeepnschrodinger mentioned this pull request Apr 3, 2020

SS-30102: Add react-lifecycles-compat polyfill to FDT to support v1.1… #523

Merged

7 tasks

wcjordan mentioned this pull request Apr 14, 2020

Console warnings for soon-to-be-deprecated React lifecycle methods #492

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unsafe react lifecycle hooks (Fixes #492) #509

Remove unsafe react lifecycle hooks (Fixes #492) #509

boxfoot commented Jan 15, 2020 •

edited

boxfoot commented Jan 16, 2020

wcjordan commented Feb 17, 2020

boxfoot commented Feb 18, 2020

wcjordan commented Feb 18, 2020

pradeepnschrodinger left a comment

pradeepnschrodinger Feb 19, 2020 •

edited

pradeepnschrodinger Feb 19, 2020

wcjordan Feb 19, 2020

pradeepnschrodinger Feb 19, 2020

wcjordan Feb 19, 2020

pradeepnschrodinger Feb 19, 2020

pradeepnschrodinger Feb 19, 2020

wcjordan commented Feb 19, 2020 •

edited

boxfoot commented Feb 19, 2020

wcjordan commented Feb 19, 2020

boxfoot commented Feb 19, 2020

wcjordan commented Feb 19, 2020

pradeepnschrodinger commented Apr 7, 2020

boxfoot commented Apr 8, 2020

wcjordan commented Apr 14, 2020

Remove unsafe react lifecycle hooks (Fixes #492) #509

Remove unsafe react lifecycle hooks (Fixes #492) #509

Conversation

boxfoot commented Jan 15, 2020 • edited

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

boxfoot commented Jan 16, 2020

wcjordan commented Feb 17, 2020

boxfoot commented Feb 18, 2020

wcjordan commented Feb 18, 2020

pradeepnschrodinger left a comment

Choose a reason for hiding this comment

pradeepnschrodinger Feb 19, 2020 • edited

Choose a reason for hiding this comment

pradeepnschrodinger Feb 19, 2020

Choose a reason for hiding this comment

wcjordan Feb 19, 2020

Choose a reason for hiding this comment

pradeepnschrodinger Feb 19, 2020

Choose a reason for hiding this comment

wcjordan Feb 19, 2020

Choose a reason for hiding this comment

pradeepnschrodinger Feb 19, 2020

Choose a reason for hiding this comment

pradeepnschrodinger Feb 19, 2020

Choose a reason for hiding this comment

wcjordan commented Feb 19, 2020 • edited

boxfoot commented Feb 19, 2020

wcjordan commented Feb 19, 2020

boxfoot commented Feb 19, 2020

wcjordan commented Feb 19, 2020

pradeepnschrodinger commented Apr 7, 2020

boxfoot commented Apr 8, 2020

wcjordan commented Apr 14, 2020

boxfoot commented Jan 15, 2020 •

edited

pradeepnschrodinger Feb 19, 2020 •

edited

wcjordan commented Feb 19, 2020 •

edited