Initial scrollTo* props fail to render

[KamranAsif]

Description

scrollToRow, scrollToColumn, scrollLeft and scrollTop were not correctly being used to calculate initial state. #52 attempted to fix this by storing as a temporary variable; but we can use the state object to determine if the props have changed.

Motivation and Context

#55
#52

How Has This Been Tested?

Added new unit tests and tested with dev server

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.

[wcjordan]

lgtm and thanks for the test!

Do you have a summary of the approach / principles you want for handling the scroll setting? How does this fit them better than the alternative review?

[KamranAsif]

Since we are already burdened by state, we should use it to compare the props. Ideally, there should be no properties on the instance as that will make the switch to redux difficult.

As a rule of thumb, throw things into state and run calculateState to always determine new output. That single function can be then broken up in redux land

[wcjordan]

Great, thanks for the explanation. Definitely glad to see local state moved into the state object.

[IanVS]

Thanks @KamranAsif and @wcjordan! Would love to see a release with this soon.

[KamranAsif]

@IanVS We'll do a release when #58 is completed

[KamranAsif]

@IanVS published 0.7.5 https://github.com/schrodinger/fixed-data-table-2/releases/tag/v0.7.5