Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the reorder handle file #6

Merged
merged 1 commit into from
Jun 4, 2016
Merged

Conversation

wcjordan
Copy link
Member

@wcjordan wcjordan commented Jun 4, 2016

Fix annotation on FixedDataTableColumnReorderHandle.react.js so it gets published to npm as expected.

Description

Update providesModule annotation and some documentation

Motivation and Context

Publishing scripts rely on providesModule annotation for creating file to publish

Documentation on reorder column options doesn't seem to exist yet and should be added down the line

How Has This Been Tested?

Ran npm run build-npm and verified files created as expected
Installed new internal directory in a sandbox and verified project could be loaded as expected

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@KamranAsif
Copy link
Contributor

lgtm

@wcjordan wcjordan merged commit 73f84cb into master Jun 4, 2016
@wcjordan wcjordan deleted the publish_reorder_handle branch June 5, 2016 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants