removing final instance of componentWillReceiveProps #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing the deprecated methods
|
Closing this following the discussion in #492 (comment), but feel free to reopen or continue the discussion if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the final usage of
componentWillReceivePropsthat causes deprecation warningsMotivation and Context
Github issue #492 - React has already deprecated
componentWillReceivePropsand plans a breaking change in v18. In the meantime, this causes console warnings for users.How Has This Been Tested?
Console tests all pass. The sample site (
test:server) also appears to be fully functional.Screenshots (if appropriate):
Types of changes
Checklist: