Merge master to v2.0-beta #685

pradeepnschrodinger · 2023-06-27T05:29:15Z

Description

This merges master (v1.2.19) to our v2.0-beta branch in preparation of the v2 release.

How Has This Been Tested?

Tested local examples.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.

Tie up setting up and cleaning up listeners to lifecycle methods under the assumption that lifecycle methods like `componentDidMount`/`componentWillUnmount` might be called multiple times for the same instance.

Expose cell visibility through a new cell renderer prop, named `isVisible`.

React runs `componentWillUnmount` prior to resetting refs through ref callbacks. This caused a NPE in our ref callback since it attempted to use `_wheelHandler` which had already gotten cleaned up in `componentWillUnmount`. Fixed with a simple null guard check against _wheelHandler.

Typo came through #658

Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits/v3.1.4) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This reverts commit 3afc224.

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Use ReactDOM.flushSync() to flush scrollbar thumb updates. Starting from React 18, React batches multiple state updates together for improving performance. While this is generally good, the legacy code in our scrollbar component (for whatever reason) expects state updates to be unbatched. This leads to #668, where the scrollbar doesn't move as fast as the user's cursor when they drag the scrollbar thumb, making them go out of sync. I'm fixing this by using ReactDOM's flushSync API to make sure that the state update is flushed immediately. Read more on automatic batching by React here: reactwg/react-18#21

Adds a polyfill for globalThis. This also changes usages of `global` to `globalThis`. This was necessary for clients using FDT in Vite, since Vite doesn't seem to be defining/shimming `global`.

#676)

FDT is a bit aggressive in preventing default scroll handlers when touch scroll is enabled. This leads to mouse events like clicks not working when they originate from the table. The changeset here relaxes this by making sure we only prevent the default behavior for `touchmove` events instead of `touchstart` and `touchend`.

pradeepnschrodinger · 2023-06-29T05:06:59Z

src/FixedDataTable.js

-      this.props.stopScrollDefaultHandling,
-      this.props.stopScrollPropagation
-    );
+    this._setupHandlers();


The registration of the scroll/touch handlers have been moved to a new helper _setupHandlers().
See #657 for more details.

pradeepnschrodinger · 2023-06-29T05:11:39Z

src/FixedDataTableBufferedRows.js

-          this._staticRowArray[i] = null;
-          continue;
-        }
+      const rowIndex = defaultTo(


From #677 where there's an extra guard check to ensure rowIndex doesn't go out of bounds.

pradeepnschrodinger · 2023-06-29T05:12:26Z

src/FixedDataTableCell.js

+    /**
+     * Whether this cell is visible (i.e, inside the viewport) or not.
+     */
+    isVisible: PropTypes.bool.isRequired,


From #658 where we expose isVisible cell prop to the cell renderer so that the client can easily figure out if a given cell is within the visible viewport.

pradeepnschrodinger · 2023-06-29T05:13:36Z

src/ReactTouchHandler.js

@@ -95,10 +95,6 @@ class ReactTouchHandler {
  }

  onTouchStart(/*object*/ event) {
-    if (this._preventDefault) {


From #679, where we don't prevent default the touch handlers for onTouchStart and onTouchEnd events.

This is based on the suggestion from MDN docs (https://developer.mozilla.org/en-US/docs/Web/API/Touch_events#handling_clicks).

Since calling preventDefault() on a touchstart or the first touchmove event of a series prevents the corresponding mouse events from firing, it's common to call preventDefault() on touchmove rather than touchstart. That way, mouse events can still fire and things like links will continue to work. Alternatively, some frameworks have taken to re-firing touch events as mouse events for this same purpose.

pradeepnschrodinger · 2023-06-29T05:14:02Z

src/plugins/Scrollbar.js

+     *
+     * (Read more on automatic batching by React here: https://github.com/reactwg/react-18/discussions/21)
+     */
+    const flushSync = ReactDOM.flushSync || ((fn) => fn()); // ReactDOM.flushSync doesn't exist in older versions of React


pradeepnschrodinger · 2023-06-29T05:15:06Z

src/vendor_upstream/core/cancelAnimationFramePolyfill.js

-  global.oCancelAnimationFrame ||
-  global.msCancelAnimationFrame ||
-  global.clearTimeout;
+  globalThis.cancelAnimationFrame ||


From #674, where global doesn't exist in vitejs environments, so we instead use a polyfilled version of globalThis (which is standard).

pradeepnschrodinger · 2023-06-29T05:15:48Z

yarn.lock

@@ -3385,9 +3385,9 @@ decimal.js@^10.3.1:
  integrity sha512-V0pfhfr8suzyPGOx3nmq4aHqabehUZn6Ch9kyFpV79TGDTWFmHqUqXdabR7QHqxzrYolF4+tVmJhUG4OURg5dQ==

 decode-uri-component@^0.2.0:


dependabot update -- #665

pradeepnschrodinger · 2023-06-29T05:16:31Z

yarn.lock

@@ -5748,9 +5748,9 @@ loader-runner@^2.4.0:
  integrity sha512-Jsmr89RcXGIwivFY21FcRrisYZfvLMTWx5kOLc+JTxtpBOG6xML0vzbc6SEQG2FO9/4Fc3wW4LVcB5DmGflaRw==

 loader-utils@^1.1.0, loader-utils@^1.2.3, loader-utils@^1.4.0:


dependabot update -- #660

pradeepnschrodinger · 2023-06-29T05:16:48Z

yarn.lock

@@ -8081,9 +8081,9 @@ semver-compare@^1.0.0:
  integrity sha1-De4hahyUGrN+nvsXiPavxf9VN/w=

 semver-regex@^3.1.2:


dependabot updates -- #636

AmanGupta2708 · 2023-07-11T16:49:17Z

LGTM !!
Let also grab changes of #686 before merging.

pradeepnschrodinger · 2023-07-11T18:21:11Z

LGTM !! Let also grab changes of #686 before merging.

There's a decent no:of conflicts. I'll make another PR.

pradeepnschrodinger and others added 26 commits June 30, 2022 13:48

Version 1.2.11

3151457

Fix NPE in StrictMode (#657)

f9e36cb

Tie up setting up and cleaning up listeners to lifecycle methods under the assumption that lifecycle methods like `componentDidMount`/`componentWillUnmount` might be called multiple times for the same instance.

Version 1.2.12

428aba4

Expose cell visibility information to cell renderers (#658) (Fixes #650)

5a22caf

Expose cell visibility through a new cell renderer prop, named `isVisible`.

Version 1.2.13

e0140f3

Version 1.2.14

1e10482

Fix PropTypes typo (boolean -> bool)

bc27879

Typo came through #658

Version 1.2.15

40e3447

Revert "Bump decode-uri-component from 0.2.0 to 0.2.2 (#665)" (#670)

bcc1e62

This reverts commit 3afc224.

Version 1.2.16

105c485

Polyfill globalThis (#674) (Fixes #673)

3e24f9c

Adds a polyfill for globalThis. This also changes usages of `global` to `globalThis`. This was necessary for clients using FDT in Vite, since Vite doesn't seem to be defining/shimming `global`.

Version 1.2.17

556c30f

Fix Error when refreshing data in table with smaller data (#667) (Fixes

66b3a07

#676)

Version 1.2.18

0ea030d

Merge branch 'v1.2.x'

862ca71

Version 1.2.19

0e693c7

Merge branch 'v1.2.x'

ec62b2d

Merge branch 'master' into merge-v2.0-beta-master

806ba05

pradeepnschrodinger requested review from somavara, abhisheksingh2410, karry08 and AmanGupta2708 June 27, 2023 05:29

pradeepnschrodinger assigned karry08 and AmanGupta2708 Jun 27, 2023

pradeepnschrodinger commented Jun 29, 2023

View reviewed changes

Merge branch 'v2.0-beta' into merge-v2.0-beta-master

703d1c9

AmanGupta2708 approved these changes Jul 11, 2023

View reviewed changes

pradeepnschrodinger merged commit 2d10594 into v2.0-beta Jul 11, 2023
6 checks passed

pradeepnschrodinger deleted the merge-v2.0-beta-master branch July 11, 2023 18:20

pradeepnschrodinger mentioned this pull request Jul 11, 2023

Merge master to v2.0-beta #690

Merged

7 tasks

pradeepnschrodinger added this to the v2.0 milestone Jul 11, 2023

pradeepnschrodinger added the v2.0-beta Tickets targeting the v2.0-beta branch. label Jul 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge master to v2.0-beta #685

Merge master to v2.0-beta #685

pradeepnschrodinger commented Jun 27, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

pradeepnschrodinger Jun 29, 2023

AmanGupta2708 commented Jul 11, 2023

pradeepnschrodinger commented Jul 11, 2023

		@@ -3385,9 +3385,9 @@ decimal.js@^10.3.1:
		integrity sha512-V0pfhfr8suzyPGOx3nmq4aHqabehUZn6Ch9kyFpV79TGDTWFmHqUqXdabR7QHqxzrYolF4+tVmJhUG4OURg5dQ==

		decode-uri-component@^0.2.0:

		@@ -5748,9 +5748,9 @@ loader-runner@^2.4.0:
		integrity sha512-Jsmr89RcXGIwivFY21FcRrisYZfvLMTWx5kOLc+JTxtpBOG6xML0vzbc6SEQG2FO9/4Fc3wW4LVcB5DmGflaRw==

		loader-utils@^1.1.0, loader-utils@^1.2.3, loader-utils@^1.4.0:

		@@ -8081,9 +8081,9 @@ semver-compare@^1.0.0:
		integrity sha1-De4hahyUGrN+nvsXiPavxf9VN/w=

		semver-regex@^3.1.2:

Merge master to v2.0-beta #685

Merge master to v2.0-beta #685

Conversation

pradeepnschrodinger commented Jun 27, 2023

Description

How Has This Been Tested?

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmanGupta2708 commented Jul 11, 2023

pradeepnschrodinger commented Jul 11, 2023