Fixing column dragging for fixed columns #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcjordan
reviewed
Nov 2, 2016
|
|
||
| var fixedColumnsWidth = this.state.bodyFixedColumns.reduce((sum, column) => sum + column.props.width, 0); | ||
| var relativeWidth = this.props.width - fixedColumnsWidth; | ||
| if (!isFixedColumn) { |
There was a problem hiding this comment.
interesting, so this means we won't scroll through fixed columns but I guess there's no use case for that.
|
lgtm, but you mean fixed columns, not fixed rows, right? |
|
Wops, yeah, I'll update the title |
KamranAsif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dragging a fixed column won't attempt to scroll the grid
Motivation and Context
SS-17697
How Has This Been Tested?
Tested in column draggable example and in LD
Types of changes
Checklist: