Reset isColumnReordering properly on stop #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamranAsif
reviewed
Nov 12, 2016
| @@ -759,7 +759,7 @@ var FixedDataTable = React.createClass({ | |||
| var reorderColumn = this.state.columnReorderingData.columnKey; | |||
|
|
|||
| this.setState({ | |||
| isReordering: false, | |||
| isColumnReordering: false, | |||
There was a problem hiding this comment.
If only we had unit tests :/
|
Nice catch. We need to remember to remove the code from from GridHeader.jsx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were changing the wrong state variable on isColumnReordering stop. This is probably why some complained about needing to set the prop manually.
Motivation and Context
Use correct state variable when stopping column reorder. May fix issues of needing to set a prop when stopping column reorder.
How Has This Been Tested?
Ran the examples.
Screenshots (if appropriate):
Types of changes
Checklist: