Column key is regenerated automatically even if key is already defined #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamranAsif
reviewed
Nov 28, 2016
| @@ -82,7 +82,7 @@ var FixedDataTableCellGroupImpl = React.createClass({ | |||
| if (!recycable || ( | |||
| currentPosition - props.left <= props.width && | |||
| currentPosition - props.left + columnProps.width >= 0)) { | |||
| var key = 'cell_' + i; | |||
| var key = columnProps.columnKey || 'cell_' + i; | |||
There was a problem hiding this comment.
@wcjordan There was discussion of adding a unique check for column keys. Do we still want to include that?
There was a problem hiding this comment.
Naw, I was afraid we were breaking backwards compatibility. But if we already have a documented requirement that column keys are unique, then no need.
|
LGTM |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #84
Description
Changed generation key for Cell. For now we using columnKey as key when columnKey provided in props
Motivation and Context
Cell was recreated each time after changing key(after hiding). Now it is only update
How Has This Been Tested?
It is tested on example in Chrome
Types of changes
Checklist: