Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch CMakeLists #73

Merged
merged 2 commits into from
Apr 27, 2022
Merged

patch CMakeLists #73

merged 2 commits into from
Apr 27, 2022

Conversation

mefuller
Copy link
Contributor

Modify CMakeLists.txt to place files in correct lib dir (e.g. on lib64 systems)

Copy link
Collaborator

@d-b-w d-b-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the symptom of the current problematic configuration? Is this the most idiomatic way to address the symptom?

CMakeLists.txt Outdated Show resolved Hide resolved
@d-b-w d-b-w requested a review from ricrogz April 25, 2022 23:47
use ${CMAKE_INSTALL_LIBDIR} variable

Co-authored-by: Dan N <dan.nealschneider@schrodinger.com>
Copy link
Collaborator

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ricrogz
Copy link
Collaborator

ricrogz commented Apr 26, 2022

Hm, I think we need to update some of the CI build instructions

@mefuller
Copy link
Contributor Author

thanks @ricrogz and @d-b-w

for reference, the Fedora package is visible at https://src.fedoraproject.org/rpms/maeparser

ricrogz added a commit to schrodinger/coordgenlibs that referenced this pull request Apr 26, 2022
@d-b-w d-b-w merged commit e47c550 into schrodinger:master Apr 27, 2022
@d-b-w
Copy link
Collaborator

d-b-w commented Apr 27, 2022

Thanks for this, @mefuller

By the way - who writes the package documentation? Is there some metadata that we should add here that would make it easier for package managers like yourself to automatically generate the documentation? It looks like it's independently written, but based on the README.

@mefuller
Copy link
Contributor Author

mefuller commented Apr 27, 2022

Independently generated - I copied it in.
No, I don't think there's anything you really need to do. This was a really easy package to generate because it's a tidy, well-organized repo.

d-b-w pushed a commit to schrodinger/coordgenlibs that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants