node-gyp rebuild error

[christian2345]

Hi,

I am trying to install parquetjs and keep running into install errors.
I did use npm install --global --production windows-build-tools successfully,
using now Win10, node v6.11.3 and
{ npm: '3.10.10',
ares: '1.10.1-DEV',
http_parser: '2.7.0',
icu: '58.2',
modules: '48',
node: '6.11.3',
openssl: '1.0.2l',
uv: '1.11.0',
v8: '5.1.281.107',
zlib: '1.2.11' }

The error log is attached below:
parquetjs_debug.log

[schroffl]

I'll take a look at it :)

[christian2345]

Thanks a million ------------------- chris.schmitzer@gmx.atAm 16.08.18, 11:10, schroffl <notifications@github.com> schrieb: I'll take a look at it :) —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/schroffl/node-lzo","title":"schroffl/node-lzo","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/schroffl/node-lzo"}},"updates":{"snippets":[{"icon":"PERSON","message":"@schroffl in #9: I'll take a look at it :)"}],"action":{"name":"View Issue","url":"#9 (comment)"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#9 (comment)", "url": "#9 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [schroffl/node-lzo] node-gyp rebuild error (#9)", "sections": [ { "text": "", "activityTitle": "**schroffl**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@schroffl", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"schroffl/node-lzo\",\n\"issueId\": 9,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"schroffl/node-lzo\",\n\"issueId\": 9\n}" }, { "targets": [ { "os": "default", "uri": "#9 (comment)" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 368942031\n}" } ], "themeColor": "26292E" } ]

[schroffl]

You replied via E-Mail, right? Because GitHub added a lot of json to the bottom of your response.
I don't think there's any confidential information in there, but you might want to check it nonetheless.

[christian2345]

correct - I'l rather not do this in the future ;-)

[christian2345]

UPDATE: I did a system restart and NPM could do a build (sequential instead of paralell) with a number of warnings; however, the require("parquetjs") statement threw an error - don't know if it helps

......\node_modules\parquetjs\lib\reader.js:49
async next() {
^^^^

SyntaxError: Unexpected identifier
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:542:28)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (C:@chris@AWS\VS2017_projects\Lamba_ProcessFELstream\Lambda Function1\node_modules\parquetjs\parquet.js:1:78)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
Press any key to continue...

[christian2345]

NPM install had been run from within VisualStudio 2017

[schroffl]

I think you have to update your node.js, because as far as I know the async keyword wasn't available back in Version 6.11.3.

Another thing you could do is to check whether building this package from source works on your machine. Here's a small command that should exit successfully:

git clone https://github.com/schroffl/node-lzo && cd node-lzo && npm run configure && npm run build

Can you run this and tell me if it built?

[christian2345]

THANKS! I did install node v8.11.4 and your recommendation worked out allright, see below.
I'll need to check on the VS2017 installation now ...

C:\Program Files\nodejs>git clone https://github.com/schroffl/node-lzo && cd node-lzo && npm run configure && npm run build
Cloning into 'node-lzo'...
remote: Counting objects: 179, done.
Receiving objects: 54% (97/179) 0 (delta 0), pack-reused 179
Receiving objects: 100% (179/179), 77.19 KiB | 705.00 KiB/s, done.
Resolving deltas: 100% (89/89), done.

lzo@0.4.3 configure C:\Program Files\nodejs\node-lzo
node-gyp configure

C:\Program Files\nodejs\node-lzo>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" configure ) else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" configure )

lzo@0.4.3 build C:\Program Files\nodejs\node-lzo
node-gyp build

C:\Program Files\nodejs\node-lzo>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" build ) else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" build )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
minilzo.c
lzo.cc
win_delay_load_hook.cc
Creating library C:\Program Files\nodejs\node-lzo\build\Release\node_lzo.lib and object C:\Program Files\nodejs\no
de-lzo\build\Release\node_lzo.exp
Generating code
Finished generating code
node_lzo.vcxproj -> C:\Program Files\nodejs\node-lzo\build\Release\node_lzo.node
node_lzo.vcxproj -> C:\Program Files\nodejs\node-lzo\build\Release\node_lzo.pdb (Full PDB)

C:\Program Files\nodejs\node-lzo>node -v
v8.11.4

[schroffl]

Alright, this looks fine to me. What happens with the new node version when you try to install parquetjs?

[christian2345]

Well, I got NPM to load the package allright, however the initialisation (require....) creats some strange errors. I'm gonna bother the parquetjs authors on ironSource, they have numerous open issues - not even sure the latest version is supposed to run...
Thanks for your help, anyway

[schroffl]

Okay, I wish you the best of luck to get it resolved quickly :)
It could very well be that there's a bug in this package though. If you experience anything weird again, feel free to create a new issue.

[Naisunev]

Dear Schroffl, I'm having a similar issue where i'm on windows 10, node 12.0 and node-gyp rebuild fails.
Errors generally look like:

• node_modules\lzo\lib\lzo.cc(34): error C2065: 'Handle': undeclared identifier
  and
• node-gyp\12.0.0\include\node\v8.h(3356): note: see declaration of 'v8::Object'

[schroffl]

@Naisunev Noted, I will investigate it tomorrow :)