Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylinder.type !== CANNON.Shape.types.CYLINDER #329

Open
donmccurdy opened this issue Jan 18, 2017 · 0 comments
Open

cylinder.type !== CANNON.Shape.types.CYLINDER #329

donmccurdy opened this issue Jan 18, 2017 · 0 comments

Comments

@donmccurdy
Copy link

donmccurdy commented Jan 18, 2017 •
edited
Loading

The cylinder constructor invokes the ConvexPolyhedron constructor, and ends up with the CONVEXPOLYHEDRON value assigned to this.type.

The obvious fix seems to break things more, and collisions aren't computed as expected.
@donmccurdy donmccurdy changed the title cylinder.type !== CANNON.Shape.type.CYLINDER cylinder.type !== CANNON.Shape.types.CYLINDER Jan 18, 2017
@marcofugaro marcofugaro mentioned this issue Dec 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@donmccurdy