Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSLLabs scan results filtering per Asset broken #202

Closed
Thijssss opened this issue Jun 3, 2015 · 0 comments
Closed

SSLLabs scan results filtering per Asset broken #202

Thijssss opened this issue Jun 3, 2015 · 0 comments

Comments

@Thijssss
Copy link

Thijssss commented Jun 3, 2015

When an asset is selected to view the findings, only a few or no results are shown for a scan done using the SSLLabs scanner. The reason is that in SeccubusFindings.pm (calll made by the browser to getFindings.pl) uses = to compare the IP or host values. SSLLabs returns these in two forms:

1: www.yoursite.com
2: www.yoursite.com/127.0.0.1

If the query gives anything it will be those matching form 1, an IP = "wwww.yoursite.com/127.0.0.1" won't ever give any result. Reversing the check and using LIKE solves this for me:

:/opt/seccubus/SeccubusV2# diff SeccubusFindings.pm SeccubusFindings.pm_org
133c133
<                               asset_hosts.asset_id = assets.id and (findings.`host` like CONCAT('%',asset_hosts.ip,'%') or asset_hosts.`host` = findings.`host`)

---
>                               asset_hosts.asset_id = assets.id and (asset_hosts.ip = findings.`host` or asset_hosts.`host` = findings.`host`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant