Fix NBE report parsing with OpenVAS. #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With current debian versions of OpenVAS retrieving the report breaks. Original code was very fragile, in fact. Replaced the search for the report content with a regular expression that should not break so easily. Note: The OpenVAS XML output does not validate as proper XML. That's the root of this problem - since it can't be validated the script resorts to manual text parsing, which naturally breaks when the output format changes even slightly. Note2: This code does not check if we actually got a result. That still needs to be added, but if that is going to be done it should be done with *everything* in this script, not just the bit that gets the report from OpenVAS's response.
…hut up about it ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current debian versions of OpenVAS retrieving the report breaks. Original code was very fragile, in fact.
Replaced the search for the report content with a regular expression that should not break so easily.
Note: The OpenVAS XML output does not validate as proper XML.
That's the root of this problem - since it can't be validated the script resorts to manual text parsing, which naturally breaks when the output format changes even slightly.
Note2: This code does not check if we actually got a result. That still needs to be added, but if that is going to be done it should be done with everything in this script, not just the bit that gets the report from OpenVAS's response.