Skip to content

Commit

Permalink
fixing tests for #9
Browse files Browse the repository at this point in the history
  • Loading branch information
iheitlager committed Apr 17, 2017
1 parent 45e652a commit 9aa0115
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
2 changes: 0 additions & 2 deletions data_migrator/transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from data_migrator.exceptions import DataException, ValidationException
from data_migrator.utils import configure_logging
from data_migrator.utils import configure_parser, default_reader
from data_migrator.utils import get_version
from data_migrator.emitters import MySQLEmitter

class Transformer(object):
Expand All @@ -21,7 +20,6 @@ class Transformer(object):
>>> t = transform.Transformer(models=[Model])
>>> t.process()
'''
def __init__(self, models=None, reader=None, argparser=None, outdir=None, emitter=MySQLEmitter):
'''
Expand Down
2 changes: 0 additions & 2 deletions data_migrator/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
from .reader import default_reader
from .log import configure_logging, default_logger
from .argparser import configure_parser, default_parser
from .version import get_version, get_docs_version, get_development_status

__all__ = [
'sql_escape',
'configure_logging', 'default_logger',
'configure_parser', 'default_parser',
'get_version', 'get_docs_version', 'get_development_status'
]
7 changes: 4 additions & 3 deletions data_migrator/utils/argparser.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
#!/usr/bin/python
# -*- coding: UTF-8 -*-

import sys
import argparse

_PARSER = None

def default_parser():
return _PARSER

def configure_parser(description=None):
def configure_parser(args=None, description=None):
global _PARSER
if not _PARSER:
description = description or 'Basic Transformer parser'
args = args or sys.argv[1:]
_PARSER = argparse.ArgumentParser(description=description)
_PARSER.add_argument('-o', '--outdir', default='results', help='output directory')
_PARSER.add_argument('-i', '--input', default='<stdin>', help='input file')
_PARSER.add_argument('--debug', action='store_true', help='enter debug mode')
_PARSER.add_argument('-q', '--quiet', action='store_true', help='quiet mode, no output')
_PARSER.add_argument('-p', '--rows', default=0, type=int, help='input rows to print')
return _PARSER.parse_args()
return _PARSER.parse_args(args)
8 changes: 8 additions & 0 deletions test/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,13 @@ def test_sql_escape(self):
for i,o in v:
self.assertEqual(utils.sql_escape(i), o)

def test_argparse(self):
'''argparse tester'''
in_args = ['-i', 'hello', '--outdir', 'world']
args = utils.configure_parser(in_args)
self.assertEquals(args.input, 'hello')
self.assertEquals(args.outdir, 'world')


if __name__ == '__main__':
unittest.main()

0 comments on commit 9aa0115

Please sign in to comment.