Enables strict mode on microchassis #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthewhite
reviewed
Nov 30, 2017
src/health.ts
Outdated
|
|
||
| public registerCheck(name: string, check) { | ||
| public registerCheck(name: string, check: any) { |
There was a problem hiding this comment.
check should be of the type Observable<boolean>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables 100% strict mode. The following changes were done to enable this:
Configobject is wrapped with<any>castsvendor.d.tstsc --initanyadded everywhere where type declaration was omitted otherwiseTo further address the issues I have created two tickets for 0.7 milestone: