Merge pull request #27 from schubergphilis/fix-example

docs: improve examples
schubergphilis · Dec 5, 2023 · 0367bdc · 0367bdc
2 parents f019768 + 638d687
commit 0367bdc
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/examples/basic/main.tf b/examples/basic/main.tf
@@ -7,14 +7,16 @@ resource "aws_kms_key" "default" {
   enable_key_rotation = true
 }
 
-resource "random_pet" "default" {
-  length = 8
+resource "random_string" "random" {
+  length  = 16
+  upper   = false
+  special = false
 }
 
 module "security_hub_manager" {
   source = "../../"
 
   kms_key_arn    = aws_kms_key.default.arn
-  s3_bucket_name = "securityhub-suppressor-artifacts-${random_pet.default.id}"
+  s3_bucket_name = "securityhub-suppressor-artifacts-${random_string.random.result}"
   tags           = { Terraform = true }
 }
diff --git a/examples/jira-integration/main.tf b/examples/jira-integration/main.tf
@@ -7,8 +7,10 @@ resource "aws_kms_key" "default" {
   enable_key_rotation = true
 }
 
-resource "random_pet" "default" {
-  length = 8
+resource "random_string" "random" {
+  length  = 16
+  upper   = false
+  special = false
 }
 
 resource "aws_secretsmanager_secret" "jira_credentials" {
@@ -32,7 +34,7 @@ module "security_hub_manager" {
   source = "../../"
 
   kms_key_arn    = aws_kms_key.default.arn
-  s3_bucket_name = "securityhub-suppressor-artifacts-${random_pet.default.id}"
+  s3_bucket_name = "securityhub-suppressor-artifacts-${random_string.random.result}"
   tags           = { Terraform = true }
 
   jira_integration = {

diff --git a/examples/servicenow-integration/main.tf b/examples/servicenow-integration/main.tf
@@ -7,15 +7,17 @@ resource "aws_kms_key" "default" {
   enable_key_rotation = true
 }
 
-resource "random_pet" "default" {
-  length = 8
+resource "random_string" "random" {
+  length  = 16
+  upper   = false
+  special = false
 }
 
 module "security_hub_manager" {
   source = "../../"
 
   kms_key_arn    = aws_kms_key.default.arn
-  s3_bucket_name = "securityhub-suppressor-artifacts-${random_pet.default.id}"
+  s3_bucket_name = "securityhub-suppressor-artifacts-${random_string.random.result}"
   tags           = { Terraform = true }
 
   servicenow_integration = {