Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure ServiceNow Sync User can update Security Hub findings #24

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

sbkg0002
Copy link
Contributor

This PR adds securityhub:BatchUpdateFindings and securityhub:GetFindings to the ServiceNow Sync User to allow successful sync back of suppressed findings.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


@sbkg0002 sbkg0002 added fix Something isn't working security Solving a security issue labels Nov 21, 2023
@sbkg0002 sbkg0002 changed the title Ensure ServiceNow Sync User can update Security Hub findings fix: Ensure ServiceNow Sync User can update Security Hub findings Nov 21, 2023
jverhoeks
jverhoeks previously approved these changes Nov 21, 2023
Copy link

@jverhoeks jverhoeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbkg0002 sbkg0002 merged commit dc46fc9 into main Nov 21, 2023
7 checks passed
@shoekstra shoekstra deleted the add-snow-user-privileges branch November 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Something isn't working security Solving a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants