feat: ask_scm_branch_on_launch for job_template #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit confused how my PR could be blocked by other people's changes that must have already been merged the same way :-) |
|
Lots of tests failing in things that weren't changed? |
|
Hey, thanks for the contribution! I will make a new minor release. Sadly the tests have drifted quite some time ago,based on betamax recordings and were not very well thought of for all provided data and nobody realized for quite some time, which means that they are now requiring redoing from scratch for the current version of the service. Sadly no time for that but would love the help if anyone is up for it :) |
|
v3.15.0 is uploaded with your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted my job launcher to be able to validate AWX job template settings and this one was missing.