Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve contribution documentation #35

Closed
schuderer opened this issue Jul 24, 2019 · 1 comment · Fixed by #39
Closed

improve contribution documentation #35

schuderer opened this issue Jul 24, 2019 · 1 comment · Fixed by #39
Assignees
Labels
good first issue Good for newcomers

Comments

@schuderer
Copy link
Owner

schuderer commented Jul 24, 2019

Missing info in CONTRIBUTING:

Add the upstream remote. This saves a reference to the main scikit-learn
repository, which you can use to keep your repository synchronized
with the latest changes:

$ git remote add upstream https://github.com/scikit-learn/scikit-learn.git

...

It is often helpful to keep your local branch synchronized with the latest
changes of the main scikit-learn repository:

$ git fetch upstream
$ git merge upstream/master

NOTE: it's preferrable to (if possible) rebase instead of merging (merging creates a lot of meaningless merge commits). In our doc, the last suggested command should probably be:

$ git rebase upstream/master
@schuderer schuderer added the good first issue Good for newcomers label Jul 28, 2019
@gosiarorat
Copy link
Contributor

i am taking the issue

gosiarorat added a commit to gosiarorat/mllaunchpad that referenced this issue Jul 30, 2019
gosiarorat added a commit to gosiarorat/mllaunchpad that referenced this issue Aug 2, 2019
gosiarorat added a commit to gosiarorat/mllaunchpad that referenced this issue Aug 5, 2019
schuderer pushed a commit that referenced this issue Aug 5, 2019
* Closes #35: Fixes mistake in pip install command, adds docstyle requirements, adds troubleshooting tip on installing requirements.

* Update CONTRIBUTING.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants