Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message "mllaunchpad.wsgi: Config file could not be loaded" #61

Closed
schuderer opened this issue Jan 29, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@schuderer
Copy link
Owner

schuderer commented Jan 29, 2020

This error also occurs if loading a previous model fails during the the ModelApi initialization. The try-catch block in the wsgi module mistakenly assumes that FileNotFoundError can only occur when loading the config, but it can also occur on initializing ModelApi (if the model could not be loaded from the model store). See:

ModelApi(conf, application)

Should probably be handled separately.

@schuderer schuderer added the bug Something isn't working label Jan 29, 2020
@schuderer schuderer added the good first issue Good for newcomers label Feb 8, 2020
@schuderer schuderer added this to To do in Release 1.0.0 tracker via automation Feb 8, 2020
@bobplatte
Copy link
Collaborator

I will work on this issue.

@schuderer
Copy link
Owner Author

schuderer commented Feb 20, 2020

Thanks Bob!

There was a mistake in the issue description, it said „The try-catch block in the wsgi module mistakenly assumes that FileNotFoundError can only occur when loading the api.“

I edited it to say: „The try-catch block in the wsgi module mistakenly assumes that FileNotFoundError can only occur when loading the config, but it can also occur on initializing ModelApi (if the model could not be loaded from the model store)

schuderer added a commit to bobplatte/mllaunchpad that referenced this issue Feb 21, 2020
Release 1.0.0 tracker automation moved this from To do to Done Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

2 participants