Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC-901 student homework archive #1052

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

gisderdube
Copy link
Contributor

backend pull can be found here: hpi-schul-cloud/schulcloud-server#486

Copy link
Contributor

@adrianjost adrianjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wurde hier im client irgendwas gemacht, außer den linter/prettier laufen zu lassen?

@CeEv
Copy link
Contributor

CeEv commented Feb 20, 2019

Ein return wurde hinzugefügt. Aber es wäre sicher hilfreich wenn linter und fix extra commits wären, damit man den fix schneller findet.
https://github.com/schul-cloud/schulcloud-client/pull/1052/files#diff-a4ac6e6e6e3e0b37a9751790925048dcR244

@CeEv CeEv merged commit ffdfeb6 into N21/merge Feb 20, 2019
@CeEv CeEv deleted the SC-901-student-homework-archive branch February 20, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants