Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mdx file extension #42

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Allow mdx file extension #42

merged 1 commit into from
Mar 18, 2021

Conversation

phartenfeller
Copy link
Contributor

First off cool plugin!

I installed it and noticed that it does not work for me because I use .mdx as file extension. I just changed 3 lines to also make your plugin work with it.

I quickly tested it and it seems to work well.

MDX is a popular Markdown extension which allows JSX: https://mdxjs.com/
So it's mostly normal MD and the different file extension states that I'm sure what I am doing with all the JSX 馃槃 .

@schultyy
Copy link
Owner

Hi!
Thank you so much for submitting this PR! I had no idea about MDX but this is definitely a good change. Merging!

Copy link
Owner

@schultyy schultyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me! 馃殺

@schultyy schultyy merged commit 9044cb4 into schultyy:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants