Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for Cheerio compatibility #10

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Update dependencies for Cheerio compatibility #10

merged 1 commit into from
Jul 15, 2021

Conversation

vinialves008
Copy link
Contributor

No description provided.

@arlopezg
Copy link

arlopezg commented Jul 13, 2021 •
edited
Loading

Hey there,

This solves an issue I've just run into while compiling a single template file.

cheerio is not a function

Is there anything stopping this from being merged/reviewed? @schwarzdavid

@arlopezg arlopezg mentioned this pull request Jul 13, 2021
Closed
@vinialves008
Copy link
Contributor Author

I do not think so.

@arlopezg
Copy link

I made a ticket for better visibility and context #13

@vinialves008
Copy link
Contributor Author

ok

This was linked to issues Jul 14, 2021
TypeError: cheerio is not a function #14
Closed
cheerio is not a function #13
Closed
@schwarzdavid schwarzdavid changed the title Ajuste dependencia para compatibilidade Cheerio Update dependencies for Cheerio compatibility Jul 14, 2021
@schwarzdavid
Copy link
Owner

schwarzdavid commented Jul 14, 2021 •
edited
Loading

I will clean up the file changes a bit so that there are no unnecessary line (https://github.com/schwarzdavid/bootstrap-email/pull/10/files#diff-41c34a700e95afbb4dfef662948c9a1c240c03f3eeb2f95bd975412c0807d29dR99 for example) changes in the log and merge tonight

@arlopezg
Copy link

arlopezg commented Jul 15, 2021 via email •
edited
Loading

schwarzdavid
schwarzdavid requested changes Jul 15, 2021
View reviewed changes
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/BootstrapEmail.js Show resolved Hide resolved
src/BootstrapEmail.js Show resolved Hide resolved
src/BootstrapEmail.js Show resolved Hide resolved
src/lib/ElementHelper.js Show resolved Hide resolved
src/lib/ElementHelper.js Show resolved Hide resolved
src/lib/ElementHelper.js Show resolved Hide resolved
src/lib/ElementHelper.js Show resolved Hide resolved
test/ElementHelper.spec.js Show resolved Hide resolved
@schwarzdavid schwarzdavid self-assigned this Jul 15, 2021
@schwarzdavid schwarzdavid merged commit 6cedf1d into schwarzdavid:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwarzdavid schwarzdavid schwarzdavid approved these changes

Assignees

@schwarzdavid schwarzdavid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: cheerio is not a function cheerio is not a function
3 participants
@vinialves008 @arlopezg @schwarzdavid