Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using sizeof(struct foo) is a bad idea for serialization #47

Open
schwehr opened this issue Jul 10, 2015 · 1 comment
Open

using sizeof(struct foo) is a bad idea for serialization #47

schwehr opened this issue Jul 10, 2015 · 1 comment
Labels
bug gsf c

Comments

@schwehr
Copy link
Owner

schwehr commented Jul 10, 2015

The character array needs to be 13 to allow for a trailing \0. However, that bumps the struct size up to 16 causing the gsf write code to write a 16 byte block instead of the original 12.

gsfHeader uses the size of the struct to determine the size of what to write.
@schwehr schwehr changed the title gsfHeader uses the size of the struct to determine the size of what to write. using sizeof(struct foo) is a bad idea for serialization Jul 10, 2015
@schwehr
Copy link
Owner Author

schwehr commented Jul 10, 2015

The issue was triggered via 6426eaf

The original issue: CID 113091 https://scan8.coverity.com/reports.htm#v26674/p11182/fileInstanceId=6388473&defectInstanceId=2398076&mergedDefectId=113091&eventId=2398076-0

schwehr added a commit that referenced this issue Jul 11, 2015
@schwehr
Do not use sizeof a struct for the header record size. #47
0b0cd72
@schwehr schwehr mentioned this issue Jul 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug gsf c
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schwehr