Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on rand details for testing t/libravatar.t #7

Closed
schwern opened this issue Aug 4, 2016 · 0 comments
Closed

Don't rely on rand details for testing t/libravatar.t #7

schwern opened this issue Aug 4, 2016 · 0 comments

Comments

@schwern
Copy link
Owner

schwern commented Aug 4, 2016

Libravatar::URL uses rand() to pick a hostname out of a federated list of servers. t/libravatar.t sets srand to be able to predict how Libravatar::URL will behave. Unfortunately sometimes Perl uses different implementations of rand that produce different results.

Make the test deterministic some other way.

See http://matrix.cpantesters.org/?dist=Gravatar-URL%201.06;os=mswin32;perl=5.18.2;reports=1 for examples of failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant