Skip to content

Commit

Permalink
do_exec needs no compatibility version in mathoms.c as it's not in th…
Browse files Browse the repository at this point in the history
…e API.

9555a68 replaced it with a macro and added the full-name version in
mathoms.c to retain compatibility with any program whose source code uses
the full name. However, as do_exec was never in the API, no program would be
using it. (It's also unconditionally explicitly not exported on various
platforms including Win32. Google Codesearch and grep.cpan.me find no users
of it outside the core.)
  • Loading branch information
nwc10 committed Jul 24, 2011
1 parent 3c234b3 commit bf4d151
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 15 deletions.
2 changes: 1 addition & 1 deletion embed.fnc
Expand Up @@ -311,7 +311,7 @@ Ap |bool |do_close |NULLOK GV* gv|bool not_implicit
p |bool |do_eof |NN GV* gv

#ifdef PERL_DEFAULT_DO_EXEC3_IMPLEMENTATION
pmb |bool |do_exec |NN const char* cmd
pm |bool |do_exec |NN const char* cmd
#else
p |bool |do_exec |NN const char* cmd
#endif
Expand Down
1 change: 0 additions & 1 deletion global.sym
Expand Up @@ -820,7 +820,6 @@ Perl_get_mstats
Perl_my_htonl
Perl_my_ntohl
Perl_my_swap
Perl_do_exec
Perl_gv_SVadd
Perl_GetVars
Perl_free_global_struct
Expand Down
11 changes: 0 additions & 11 deletions mathoms.c
Expand Up @@ -66,7 +66,6 @@ PERL_CALLCONV HE * Perl_hv_iternext(pTHX_ HV *hv);
PERL_CALLCONV void Perl_hv_magic(pTHX_ HV *hv, GV *gv, int how);
PERL_CALLCONV bool Perl_do_open(pTHX_ GV *gv, register const char *name, I32 len, int as_raw, int rawmode, int rawperm, PerlIO *supplied_fp);
PERL_CALLCONV bool Perl_do_aexec(pTHX_ SV *really, register SV **mark, register SV **sp);
PERL_CALLCONV bool Perl_do_exec(pTHX_ const char *cmd);
PERL_CALLCONV U8 * Perl_uvuni_to_utf8(pTHX_ U8 *d, UV uv);
PERL_CALLCONV bool Perl_is_utf8_string_loc(pTHX_ const U8 *s, STRLEN len, const U8 **ep);
PERL_CALLCONV void Perl_sv_nolocking(pTHX_ SV *sv);
Expand Down Expand Up @@ -685,16 +684,6 @@ Perl_do_aexec(pTHX_ SV *really, register SV **mark, register SV **sp)
}
#endif

#ifdef PERL_DEFAULT_DO_EXEC3_IMPLEMENTATION
bool
Perl_do_exec(pTHX_ const char *cmd)
{
PERL_ARGS_ASSERT_DO_EXEC;

return do_exec3(cmd,0,0);
}
#endif

/* Backwards compatibility. */
int
Perl_init_i18nl14n(pTHX_ int printwarn)
Expand Down
2 changes: 0 additions & 2 deletions proto.h
Expand Up @@ -5008,8 +5008,6 @@ PERL_CALLCONV void Perl_pending_Slabs_to_ro(pTHX);
#if defined(PERL_DEFAULT_DO_EXEC3_IMPLEMENTATION)
/* PERL_CALLCONV bool Perl_do_exec(pTHX_ const char* cmd)
__attribute__nonnull__(pTHX_1); */
#define PERL_ARGS_ASSERT_DO_EXEC \
assert(cmd)

#endif
#if defined(PERL_DONT_CREATE_GVSV)
Expand Down

0 comments on commit bf4d151

Please sign in to comment.