fix: add missing docker cli and buildx plugin when running in docker #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallAsch
commented
Oct 22, 2022
builder/cli.py
Outdated
| cleanup_buildx(old_builder, builder_name) | ||
|
|
||
|
|
||
| def setup_buildx() -> tuple: |
There was a problem hiding this comment.
Suggested change
| def setup_buildx() -> tuple: | |
| def setup_buildx() -> Tuple[str, str]: |
MarshallAsch
force-pushed
the
fix-running-in-docker
branch
from
42eb67c
to
a1996ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #123
Describe the pull request:
The docker image did not include the docker cli client or thr buildx plugin which are called directly when building multi architecture images.
This adds both binaries to the image and will setup a new buildx builder for the lifetime of the command.
Checklist: