Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal notifications leave empty element in DOM #301

Closed
todduk opened this issue May 28, 2017 · 1 comment
Closed

Modal notifications leave empty element in DOM #301

todduk opened this issue May 28, 2017 · 1 comment
Assignees
@hperrin
Labels
enhancement good first issue help wanted
Milestone
4.0.0

Comments

@todduk
Copy link

todduk commented May 28, 2017 •
edited
Loading

When you create a modal notification and then close it, either by confirming, cancelling or closing, there is an empty element left at the top of the <body>.
<div style="display: none;" class="ui-pnotify-modal-overlay"></div>

Unclear if it should be being reused or deleted, but the issue is also present on the documentation page.

When any type of notif is open and you mouseout all of the left over elements are updated in some way (possibly opacity, can't tell, sorry).
@hperrin hperrin self-assigned this May 28, 2017
@hperrin hperrin added this to the 4.0.0 milestone Jan 24, 2018
@hperrin
Copy link
Member

hperrin commented Jan 24, 2018

Ideally, the element should be destroyed when all notices in the modal stack have been closed and recreated if they are opened again.

@ghost ghost removed the ready label Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hperrin hperrin

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@hperrin @todduk