Merge pull request #67 from scidash/code-climate

Code climate
scidash · Feb 12, 2018 · 0de9a2e · 0de9a2e
2 parents 3591f59 + 97014f7
commit 0de9a2e
Show file tree

Hide file tree

Showing 35 changed files with 2,525 additions and 2,218 deletions.
diff --git a/docs/chapter2.ipynb b/docs/chapter2.ipynb
@@ -256,7 +256,7 @@
     {
      "data": {
       "text/plain": [
-       "<sciunit.scores.BooleanScore at 0x109a3e4e0>"
+       "<sciunit.scores.complete.BooleanScore at 0x10bf58a20>"
       ]
      },
      "execution_count": 10,
@@ -364,7 +364,7 @@
     "equals_1_test = EqualsTest(1, name='=1') # Test that model output equals 1.  \n",
     "equals_2_test = EqualsTest(2, name='=2') # Test that model output equals 2.  \n",
     "\n",
-    "equals_suite = sciunit.TestSuite(\"Equals test suite\", [equals_1_test, equals_2_test, equals_37_test])"
+    "equals_suite = sciunit.TestSuite([equals_1_test, equals_2_test, equals_37_test], name=\"Equals test suite\")"
    ]
   },
   {
@@ -462,7 +462,20 @@
      "data": {
       "text/html": [
        "<html><body><div>\n",
-       "<table border=\"1\" class=\"dataframe\" id=\"-6951170927268633672\">\n",
+       "<style scoped=\"\">\n",
+       "    .dataframe tbody tr th:only-of-type {\n",
+       "        vertical-align: middle;\n",
+       "    }\n",
+       "\n",
+       "    .dataframe tbody tr th {\n",
+       "        vertical-align: top;\n",
+       "    }\n",
+       "\n",
+       "    .dataframe thead th {\n",
+       "        text-align: right;\n",
+       "    }\n",
+       "</style>\n",
+       "<table border=\"1\" class=\"dataframe\" id=\"913968671956531036\">\n",
        "<thead>\n",
        "<tr style=\"text-align: right;\">\n",
        "<th></th>\n",
@@ -739,7 +752,20 @@
      "data": {
       "text/html": [
        "<html><body><div>\n",
-       "<table border=\"1\" class=\"dataframe\" id=\"-2432389546818237383\">\n",
+       "<style scoped=\"\">\n",
+       "    .dataframe tbody tr th:only-of-type {\n",
+       "        vertical-align: middle;\n",
+       "    }\n",
+       "\n",
+       "    .dataframe tbody tr th {\n",
+       "        vertical-align: top;\n",
+       "    }\n",
+       "\n",
+       "    .dataframe thead th {\n",
+       "        text-align: right;\n",
+       "    }\n",
+       "</style>\n",
+       "<table border=\"1\" class=\"dataframe\" id=\"-2295631968650733791\">\n",
        "<thead>\n",
        "<tr style=\"text-align: right;\">\n",
        "<th></th>\n",
@@ -899,5 +925,5 @@
   }
  },
  "nbformat": 4,
- "nbformat_minor": 0
+ "nbformat_minor": 2
 }
diff --git a/docs/chapter3.ipynb b/docs/chapter3.ipynb
@@ -74,7 +74,7 @@
    "source": [
     "from sciunit.capabilities import ProducesNumber\n",
     "from sciunit.scores import ZScore # One of many SciUnit score types.  \n",
-    "from sciunit import ObservationError # An exception class raised when a test is instantiated \n",
+    "from sciunit.errors import ObservationError # An exception class raised when a test is instantiated \n",
     "                                     # with an invalid observation.\n",
     "    \n",
     "class MeanTest(sciunit.Test):\n",
@@ -86,9 +86,9 @@
     "    \n",
     "    def validate_observation(self, observation):\n",
     "        if type(observation) is not dict:\n",
-    "            raise sciunit.ObservationError(\"Observation must be a python dictionary\")\n",
+    "            raise ObservationError(\"Observation must be a python dictionary\")\n",
     "        if 'mean' not in observation:\n",
-    "            raise sciunit.ObservationError(\"Observation must contain a 'mean' entry\")\n",
+    "            raise ObservationError(\"Observation must contain a 'mean' entry\")\n",
     "        \n",
     "    def generate_prediction(self, model):\n",
     "        return model.produce_number() # The model has this method if it inherits from the 'ProducesNumber' capability.\n",
@@ -214,15 +214,6 @@
    "source": [
     "score.describe()"
    ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {
-    "collapsed": true
-   },
-   "outputs": [],
-   "source": []
   }
  ],
  "metadata": {
@@ -245,5 +236,5 @@
   }
  },
  "nbformat": 4,
- "nbformat_minor": 0
+ "nbformat_minor": 2
 }